-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57166/#review168096
-----------------------------------------------------------
Fix it, then Ship it!
src/common/roles.cpp
Line 71 (original), 71-79 (patched)
<https://reviews.apache.org/r/57166/#comment240222>
Newlines in between.
src/common/roles.cpp
Lines 72 (patched)
<https://reviews.apache.org/r/57166/#comment240223>
For these error messages, how about we say something like this?
```cpp
"A role cannot start with a slash, given: '" + role + "'"
```
Here and below.
src/common/roles.cpp
Lines 82 (patched)
<https://reviews.apache.org/r/57166/#comment240220>
`s/pathElements/components/`
src/common/roles.cpp
Line 78 (original), 90 (patched)
<https://reviews.apache.org/r/57166/#comment240221>
`s/element/component/`
- Michael Park
On March 2, 2017, 10:12 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57166/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 10:12 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Role names can now contain forward slashes. Each component in a role
> name must now be validated separately.
>
>
> Diffs
> -----
>
> src/common/roles.cpp 31774a9b8f99f5efeed35b1c3e3486e05ca00f6a
> src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1
>
>
> Diff: https://reviews.apache.org/r/57166/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
|