mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.
Date Mon, 06 Mar 2017 23:30:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55887/#review167750
-----------------------------------------------------------




src/slave/slave.hpp
Lines 340 (patched)
<https://reviews.apache.org/r/55887/#comment239691>

    Yes.



src/slave/slave.cpp
Lines 1830-1840 (original), 1818-1835 (patched)
<https://reviews.apache.org/r/55887/#comment239716>

    I added check for killed tasks before checking for unscheduling of directories which kind
of brings in the original behavior.
    We can followup if we need to change the task state in such case separately.


- Anindya Sinha


On March 3, 2017, 8:08 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55887/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 8:08 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6953
>     https://issues.apache.org/jira/browse/MESOS-6953
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for action `run_tasks` on the agent's flag `acl`. Based on
> the ACL configured for `run_tasks`, a task to be launched on the agent
> can be (dis)allowed to launch on the agent.
> If a task or task group cannot be launched due to failed authorization,
> a `TASK_ERROR` Status Update shall be sent with a reason code of
> `REASON_TASK_UNAUTHORIZED` or `REASON_TASK_GROUP_UNAUTHORIZED` as
> applicable.
> Note that in case of a task group, all tasks fail if any of the tasks
> within the task group encounter the authorization error.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 857338cc54b341873c338967223c6b0138e9dc3e 
>   src/slave/slave.cpp 775f43b449ec53aa51cc5d3de448ddc7c2059bff 
> 
> 
> Diff: https://reviews.apache.org/r/55887/diff/7/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message