mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56754: Implemented a JWT secret generator.
Date Mon, 06 Mar 2017 23:25:59 GMT


> On March 3, 2017, 7:48 a.m., Greg Mann wrote:
> > src/authentication/executor/jwt_secret_generator.hpp
> > Lines 40 (patched)
> > <https://reviews.apache.org/r/56754/diff/4/?file=1651715#file1651715line40>
> >
> >     Use `override` instead of `virtual` here?
> 
> Jan Schlicht wrote:
>     Do we use that for destructors as well? Seems uncommon in that context and haven't
seen any examples in our source base.

If the destructor is overriding a virtual destructor from the base class, then it's appropriate
to use `override`. We don't make very wide use of the `override` keyword in the codebase currently
(see MESOS-4871); for an example of a place where it was recently added, see the declaration
of the `LibeventSSLSocketImpl` class in libprocess.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56754/#review167735
-----------------------------------------------------------


On March 6, 2017, 2:57 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56754/
> -----------------------------------------------------------
> 
> (Updated March 6, 2017, 2:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-7000
>     https://issues.apache.org/jira/browse/MESOS-7000
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This can be used to create a 'Secret' from a 'Principal'.
> The resulting secret will provide a JWT.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am bb917c5d1b36f5106a74914fa3a864038a95e8bb 
>   src/authentication/executor/jwt_secret_generator.hpp PRE-CREATION 
>   src/authentication/executor/jwt_secret_generator.cpp PRE-CREATION 
>   src/tests/secret_generator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56754/diff/5/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message