mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.
Date Mon, 06 Mar 2017 22:38:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57269/#review168058
-----------------------------------------------------------



Looks good, just a few minor things and we can get this committed.


src/tests/master_tests.cpp
Lines 4292-4293 (patched)
<https://reviews.apache.org/r/57269/#comment240130>

    Are you planning to test the agent endpoint as well?



src/tests/master_tests.cpp
Lines 4356 (patched)
<https://reviews.apache.org/r/57269/#comment240132>

    Can you do a sweep for using the -> operator in this test?



src/tests/master_tests.cpp
Lines 4376-4384 (patched)
<https://reviews.apache.org/r/57269/#comment240139>

    Do you want to add some `is<JSON::Array>()` asserts here?


- Benjamin Mahler


On March 3, 2017, 8:30 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57269/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 8:30 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7158
>     https://issues.apache.org/jira/browse/MESOS-7158
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test ensures that allocation roles of tasks and executors are
> exposed via `/state` endpoint of master v0 API.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp b9dfe9eb7d759550673896980cffc3909f4c0105 
> 
> 
> Diff: https://reviews.apache.org/r/57269/diff/1/
> 
> 
> Testing
> -------
> 
> Added a test `MasterTest.StateEndpointAllocationRole`
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message