mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.
Date Mon, 06 Mar 2017 20:05:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57110/#review168031
-----------------------------------------------------------


Fix it, then Ship it!




New function names look good.


src/master/master.hpp
Lines 2246 (patched)
<https://reviews.apache.org/r/57110/#comment240039>

    Can we take a const ref here to avoid the copy?



src/master/master.hpp
Lines 2413-2414 (patched)
<https://reviews.apache.org/r/57110/#comment240040>

    Ditto here.


- Benjamin Mahler


On March 6, 2017, 11:37 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57110/
> -----------------------------------------------------------
> 
> (Updated March 6, 2017, 11:37 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6627
>     https://issues.apache.org/jira/browse/MESOS-6627
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the master to handle frameworks that changes its roles.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 81320e0da3a2cd99d8dea1fbea9276296ef9e515 
>   src/master/master.cpp a15c6d8fb1f99d117eed8e9453a643ec80319a52 
> 
> 
> Diff: https://reviews.apache.org/r/57110/diff/9/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message