mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 57166: Updated role validation for hierarchical roles.
Date Mon, 06 Mar 2017 17:09:06 GMT


> On March 2, 2017, 1:21 a.m., Qian Zhang wrote:
> > src/common/roles.cpp
> > Line 71 (original), 71 (patched)
> > <https://reviews.apache.org/r/57166/diff/1/?file=1652003#file1652003line72>
> >
> >     Why can't role start with a slash? According to the design doc, it seems the
role like `/eng/frontend` is valid.
> 
> Neil Conway wrote:
>     Qian, this aspect of the hierarchical role design has changed since the design doc
was initially proposed. The design doc has been partially updated -- I'll finish updating
it shortly. The basic idea is that the syntax for hierarchical roles will just be an extension
to the current syntax -- i.e., hierarchical role names will look like `eng/dev` and `eng/prod`,
not `/eng/dev`.
> 
> Qian Zhang wrote:
>     Thanks Neil for the clarification. But with this new design, the role name is more
like a relative path rather than an absolute path, but I guess what we need is an absolute
one, so when framework tries to register a role like `eng/dev`, we will always assume it is
an absolute one (i.e., `eng` is root role), right?

Role names do not begin with `/`, but they are effectively relative paths that are interpreted
by starting from the root of the role tree.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57166/#review167623
-----------------------------------------------------------


On March 2, 2017, 6:12 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57166/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 6:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Role names can now contain forward slashes. Each component in a role
> name must now be validated separately.
> 
> 
> Diffs
> -----
> 
>   src/common/roles.cpp 31774a9b8f99f5efeed35b1c3e3486e05ca00f6a 
>   src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 
> 
> 
> Diff: https://reviews.apache.org/r/57166/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message