mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.
Date Mon, 06 Mar 2017 11:24:52 GMT


> On March 5, 2017, 12:37 p.m., Benjamin Mahler wrote:
> > src/master/master.hpp
> > Lines 1785-1786 (original), 1789-1793 (patched)
> > <https://reviews.apache.org/r/57110/diff/7/?file=1656422#file1656422line1789>
> >
> >     It looks like we should have pulled out this rename to into a separate patch
to have this be a bit cleaner, oh well.

https://reviews.apache.org/r/57329/


> On March 5, 2017, 12:37 p.m., Benjamin Mahler wrote:
> > src/master/master.hpp
> > Line 2423 (original), 2467 (patched)
> > <https://reviews.apache.org/r/57110/diff/7/?file=1656422#file1656422line2490>
> >
> >     Do you want to pull this 'source' to 'newInfo' rename patch out to unclutter
this diff?

https://reviews.apache.org/r/57330/


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57110/#review167948
-----------------------------------------------------------


On March 6, 2017, 2:57 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57110/
> -----------------------------------------------------------
> 
> (Updated March 6, 2017, 2:57 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6627
>     https://issues.apache.org/jira/browse/MESOS-6627
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 81320e0da3a2cd99d8dea1fbea9276296ef9e515 
>   src/master/master.cpp a15c6d8fb1f99d117eed8e9453a643ec80319a52 
> 
> 
> Diff: https://reviews.apache.org/r/57110/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message