mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.
Date Mon, 06 Mar 2017 02:51:26 GMT


> On March 5, 2017, 12:37 p.m., Benjamin Mahler wrote:
> > src/master/master.hpp
> > Lines 2652-2654 (patched)
> > <https://reviews.apache.org/r/57110/diff/7/?file=1656422#file1656422line2702>
> >
> >     Per the other suggestions, perhaps something like:
> >     
> >     ```
> >       bool trackingAllocationToRole(const std::string& role) const;
> >       void trackAllocationToRole(const std::string& role);
> >       void stopTrackingAllocationToRole(const std::string& role);
> >     ```

I definitely agree that we need to change this. What do you think of:
```cpp
bool isTrackedUnderRole(const std::string& role);
void trackUnderRole(const std::string& role);
void untrackUnderRole(const std::string& role);
```

Since we're keeping track of the framework under a role. That is,
a framework subscribed to a role without any allocation is still
tracked under the role.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57110/#review167948
-----------------------------------------------------------


On March 4, 2017, 7:55 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57110/
> -----------------------------------------------------------
> 
> (Updated March 4, 2017, 7:55 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6627
>     https://issues.apache.org/jira/browse/MESOS-6627
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the master to handle frameworks that changes its roles.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 37b96c07f17d3e5ba96f6eade69d86ba9e039b3d 
>   src/master/master.hpp 81320e0da3a2cd99d8dea1fbea9276296ef9e515 
>   src/master/master.cpp a15c6d8fb1f99d117eed8e9453a643ec80319a52 
>   src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a 
>   src/master/weights_handler.cpp d8047f2354322ec18b008afe44f507069b36a71f 
> 
> 
> Diff: https://reviews.apache.org/r/57110/diff/7/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message