mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Review Request 57319: Fixed a bug around temporaries in `src/master/http.cpp`.
Date Sun, 05 Mar 2017 03:23:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57319/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Neil Conway.


Repository: mesos


Description
-------

The issue is that we call `keys()` and `keys()` currently returns a temporary.
When we call `begin()` and `end()`, we're calling it on two different instances.
This has unspecified behavior.

Calling `F()` multiple times: http://melpon.org/wandbox/permlink/cV6oxFgYldXrNwjU
Calling `F()` once: http://melpon.org/wandbox/permlink/3dtBq6S0QMQ0UHld


Diffs
-----

  src/master/http.cpp 37b96c07f17d3e5ba96f6eade69d86ba9e039b3d 


Diff: https://reviews.apache.org/r/57319/diff/1/


Testing
-------

`make check`


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message