mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57282: Sent `UpdateFrameworkMessage` even to disconnected frameworks.
Date Sat, 04 Mar 2017 01:58:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57282/#review167921
-----------------------------------------------------------


Ship it!




In the summary / description: "to frameworks" -> "to agents for (dis)connected frameworks"

- Benjamin Mahler


On March 3, 2017, 9:47 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57282/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 9:47 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We used to only send `UpdateFrameworkMessage` to connected frameworks
> because it only included `PID`s. However, since now it also includes
> updates to the `FrameworkInfo`, we choose to lift this optimization and
> send it to all frameworks.
> 
> This is resolving https://reviews.apache.org/r/57110/#comment239045.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 442fbc6e884610ff4d4d62890fb8142a529026d6 
> 
> 
> Diff: https://reviews.apache.org/r/57282/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message