mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.
Date Sat, 04 Mar 2017 01:50:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57110/#review167922
-----------------------------------------------------------




src/master/master.hpp
Lines 1785-1786 (original), 1793-1797 (patched)
<https://reviews.apache.org/r/57110/#comment239911>

    On second thought, and after discussing offline, let's remove the notion of "active" from
the name and the comment here, since "active" has meant:
    
    frameworks: receiving resources
    agents: sending resources
    
    and ideally for roles it can consistently mean:
    
    role: receiving resources (i.e. at least one framework wants resources for the role)
    
    Ditto in the allocator patch.


- Benjamin Mahler


On March 3, 2017, 11:10 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57110/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 11:10 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6627
>     https://issues.apache.org/jira/browse/MESOS-6627
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the master to handle frameworks that changes its roles.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 81320e0da3a2cd99d8dea1fbea9276296ef9e515 
>   src/master/master.cpp 43e6fadb69cf3989f1c5b36808a2424800e0a0a6 
> 
> 
> Diff: https://reviews.apache.org/r/57110/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message