mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57298: Added a new libprocess test for invalid principals.
Date Sat, 04 Mar 2017 01:36:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57298/
-----------------------------------------------------------

(Updated March 4, 2017, 1:36 a.m.)


Review request for mesos, Alexander Rojas, Jan Schlicht, and Vinod Kone.


Changes
-------

Stopped using the `Principal()` default constructor.


Bugs: MESOS-7003
    https://issues.apache.org/jira/browse/MESOS-7003


Repository: mesos


Description
-------

This patch adds `HttpAuthenticationTest.InvalidPrincipal` to
libprocess to verify that requests return a 500 status code
when the authenticator fails to return a valid principal.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f 


Diff: https://reviews.apache.org/r/57298/diff/2/

Changes: https://reviews.apache.org/r/57298/diff/1-2/


Testing
-------

Testing details can be found at the end of this patch chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message