mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56618: Updated common Mesos code to use the 'Principal' type.
Date Fri, 03 Mar 2017 23:38:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56618/
-----------------------------------------------------------

(Updated March 3, 2017, 11:38 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod
Kone.


Bugs: MESOS-7003
    https://issues.apache.org/jira/browse/MESOS-7003


Repository: mesos


Description
-------

This patch updates common Mesos HTTP-related helpers,
as well as the `authorization::Subject` protobuf
message, to make use of the `Principal` type instead
of an `Option<string> principal`.


Diffs (updated)
-----

  include/mesos/authorizer/authorizer.proto 9cc75b0db17b2d0bab3f449f795cbf505c5b0f15 
  src/common/http.hpp 3d5ab59ddc4dce4d791c1b439f5e1459d1a724a4 
  src/common/http.cpp 5d75ecd8b6d2e288bebac50e7de738712858f74d 


Diff: https://reviews.apache.org/r/56618/diff/6/

Changes: https://reviews.apache.org/r/56618/diff/5-6/


Testing
-------

Testing information can be found at the end of this review chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message