mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.
Date Fri, 03 Mar 2017 22:25:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57110/#review167880
-----------------------------------------------------------




src/master/master.hpp
Lines 1785-1786 (original), 1793-1794 (patched)
<https://reviews.apache.org/r/57110/#comment239842>

    We should also update the comment here to reflect the change we're making in this patch,
and also to define "active" in this context, e.g.:
    
    ```
    // We track information about roles that are active
    // in the system. A role is active when a framework
    // subscribes to the role, and/or when there are resources
    // allocated to the role (e.g. some tasks and/or executors
    // are consuming resources under the role).
    hashmap<std::string, Role*> activeRoles;
    ```


- Benjamin Mahler


On March 3, 2017, 9:47 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57110/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 9:47 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6627
>     https://issues.apache.org/jira/browse/MESOS-6627
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 764adb18ddf09b62529c5c96f8e4dfaf7803483e 
>   src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942 
> 
> 
> Diff: https://reviews.apache.org/r/57110/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message