mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56813: Updated master handlers to use the 'Principal' type.
Date Fri, 03 Mar 2017 18:47:43 GMT


> On March 2, 2017, 10:41 p.m., Greg Mann wrote:
> > src/master/master.hpp
> > Line 746 (original), 746 (patched)
> > <https://reviews.apache.org/r/56813/diff/6/?file=1651812#file1651812line746>
> >
> >     See if we can typedef this.

Sounds like we can't :(


> On March 2, 2017, 10:41 p.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 1565-1573 (original), 1569-1577 (patched)
> > <https://reviews.apache.org/r/56813/diff/6/?file=1651813#file1651813line1569>
> >
> >     CHECK(principal->value.isSome())

In this case, and in the case of `exceededCapacity`, I changed the `principal` parameter back
to `Option<string>& principal`. It turns out these functions are only part of the
`Master::visit` call path, so they only make use of the master's internal `frameworks.principals`
map. Thus, they will always receive a string-type principal. I added a todo to change the
signature when we resolve MESOS-7202.


> On March 2, 2017, 10:41 p.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 1608-1611 (original), 1612-1615 (patched)
> > <https://reviews.apache.org/r/56813/diff/6/?file=1651813#file1651813line1612>
> >
> >     Rework to make more readable

Since this now accepts a string principal again, I reverted to the previous logging.


> On March 2, 2017, 10:41 p.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 3499-3501 (original), 3503-3504 (patched)
> > <https://reviews.apache.org/r/56813/diff/6/?file=1651813#file1651813line3503>
> >
> >     s/ANY/'ANY'/

It looks like we do quote JSON as well, so I'm leaving quotes in place. I also decided I liked
the idea of making the streaming operator smarter, so that's been updated as well.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56813/#review167754
-----------------------------------------------------------


On March 3, 2017, 6:45 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56813/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 6:45 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and
Vinod Kone.
> 
> 
> Bugs: MESOS-7003
>     https://issues.apache.org/jira/browse/MESOS-7003
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the HTTP endpoint handlers in the
> master process to accept the `Principal` type instead
> of an `Option<string>& principal`.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 37b96c07f17d3e5ba96f6eade69d86ba9e039b3d 
>   src/master/master.hpp 81320e0da3a2cd99d8dea1fbea9276296ef9e515 
>   src/master/master.cpp 2232cb7ad7c9ba7c067334d7327f592ab48e48fa 
>   src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a 
>   src/master/registrar.cpp d7134eea34102ab7b24d2f0131363bdd9005cfd3 
>   src/master/weights_handler.cpp d8047f2354322ec18b008afe44f507069b36a71f 
> 
> 
> Diff: https://reviews.apache.org/r/56813/diff/7/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message