mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56813: Updated master handlers to use the 'Principal' type.
Date Fri, 03 Mar 2017 18:46:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56813/
-----------------------------------------------------------

(Updated March 3, 2017, 6:45 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod
Kone.


Changes
-------

Added the constraint that `principal->value.isSome()` is true. Removed `createOptionalSubject()`.


Bugs: MESOS-7003
    https://issues.apache.org/jira/browse/MESOS-7003


Repository: mesos


Description
-------

This patch updates the HTTP endpoint handlers in the
master process to accept the `Principal` type instead
of an `Option<string>& principal`.


Diffs (updated)
-----

  src/master/http.cpp 37b96c07f17d3e5ba96f6eade69d86ba9e039b3d 
  src/master/master.hpp 81320e0da3a2cd99d8dea1fbea9276296ef9e515 
  src/master/master.cpp 2232cb7ad7c9ba7c067334d7327f592ab48e48fa 
  src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a 
  src/master/registrar.cpp d7134eea34102ab7b24d2f0131363bdd9005cfd3 
  src/master/weights_handler.cpp d8047f2354322ec18b008afe44f507069b36a71f 


Diff: https://reviews.apache.org/r/56813/diff/7/

Changes: https://reviews.apache.org/r/56813/diff/6-7/


Testing
-------

Testing details can be found at the end of this review chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message