mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56812: Updated agent handlers to use the 'Principal' type.
Date Fri, 03 Mar 2017 18:43:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/
-----------------------------------------------------------

(Updated March 3, 2017, 6:43 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod
Kone.


Changes
-------

Removed `createOptionalSubject()`.


Bugs: MESOS-7003
    https://issues.apache.org/jira/browse/MESOS-7003


Repository: mesos


Description
-------

This patch updates the HTTP endpoint handlers in the
agent process to accept the `Principal` type instead
of an `Option<string>& principal`.


Diffs (updated)
-----

  src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59 
  src/slave/slave.hpp 449971b6b343c7714e1d1167a55bbdfe94d2cf83 
  src/slave/slave.cpp 6ae9458cc81a7623a1837cd636156434a972004b 


Diff: https://reviews.apache.org/r/56812/diff/5/

Changes: https://reviews.apache.org/r/56812/diff/4-5/


Testing
-------

Testing details can be found at the end of this review chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message