mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56754: Implemented a JWT secret generator.
Date Fri, 03 Mar 2017 07:48:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56754/#review167735
-----------------------------------------------------------



Looks good, thanks Jan! A few comments below.


src/authentication/executor/jwt_secret_generator.hpp
Lines 31-34 (patched)
<https://reviews.apache.org/r/56754/#comment239665>

    Sorry, this comment is a bit confusing to me :) I might suggest something like:
    
    "Creates a VALUE-type secret containing a JWT. When the secret is presented to the `JWTAuthenticator`
module, the authenticator will return the principal which is provided here as an argument."



src/authentication/executor/jwt_secret_generator.hpp
Lines 40 (patched)
<https://reviews.apache.org/r/56754/#comment239659>

    Use `override` instead of `virtual` here?



src/authentication/executor/jwt_secret_generator.hpp
Lines 42-44 (patched)
<https://reviews.apache.org/r/56754/#comment239656>

    `override` implies `virtual`, so you can remove the `virtual` here.



src/authentication/executor/jwt_secret_generator.cpp
Lines 38-40 (patched)
<https://reviews.apache.org/r/56754/#comment239667>

    Should there be two newlines here?



src/tests/secret_generator_tests.cpp
Lines 45 (patched)
<https://reviews.apache.org/r/56754/#comment239670>

    I don't think this is needed?



src/tests/secret_generator_tests.cpp
Lines 53 (patched)
<https://reviews.apache.org/r/56754/#comment239672>

    The name `secrets` seems a bit weird to me, makes me think it would be a list of secrets?
Maybe `generator` instead?


- Greg Mann


On Feb. 28, 2017, 1:39 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56754/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 1:39 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-7000
>     https://issues.apache.org/jira/browse/MESOS-7000
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This can be used to create a 'Secret' from an 'AuthenticationContext'.
> The resulting secret will provide a JWT.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 76d58a0bbd77fe59ff8a81ba7a68c84dc7169750 
>   src/authentication/executor/jwt_secret_generator.hpp PRE-CREATION 
>   src/authentication/executor/jwt_secret_generator.cpp PRE-CREATION 
>   src/tests/secret_generator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56754/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message