mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 57264: Fixed ProvisionerDockerPullerTest.ROOT_RecoverNestedOnReboot.
Date Fri, 03 Mar 2017 01:41:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57264/#review167780
-----------------------------------------------------------


Ship it!




Thanks for the patch!

Not yours, we should consider replace all `os::getcwd()` in this file to `sandbox.get`.

- Gilbert Song


On March 2, 2017, 5:35 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57264/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 5:35 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Otherwise this test fails for me.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 01c06828a05bcafd5ae40191625edbd507983a99

> 
> 
> Diff: https://reviews.apache.org/r/57264/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message