mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 56210: Reused previous task status for health updates in command executor.
Date Fri, 03 Mar 2017 00:24:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56210/#review167770
-----------------------------------------------------------


Fix it, then Ship it!




Looks much cleaner. Thanks for the cleanup!


src/launcher/executor.cpp
Line 744 (original), 769 (patched)
<https://reviews.apache.org/r/56210/#comment239735>

    s/if you want status update to be create/ to create a status update/


- Vinod Kone


On Feb. 28, 2017, 3:52 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56210/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 3:52 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a new health task status update is generated in the executor, we
> have to make sure specific data is duplicated from the previous one to
> avoid shadowing of those data during reconciliation.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378 
> 
> 
> Diff: https://reviews.apache.org/r/56210/diff/5/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56213/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message