mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Review Request 57260: CMake: Refactored FindApr.cmake and FindSvn.cmake.
Date Thu, 02 Mar 2017 23:53:48 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Andrew Schwartzmeyer, Alex Clemmer, and Joris Van Remoortere.

Bugs: MESOS-6691

Repository: mesos


The logic to find APR and SVN headers/libraries are effectively the
same, except for where those headers/libraries might be found.

This commit refactors the two files into a helper that takes several
lists as arguments (lists are passed by reference in CMake) and
outputs two lists of directories.

This also removes the logic for finding `APR-util`, which is not
used in this project.


  3rdparty/stout/cmake/FindApr.cmake 13156a58a57c22044977c7220df31372e61f82f6 
  3rdparty/stout/cmake/FindPackageHelper.cmake PRE-CREATION 
  3rdparty/stout/cmake/FindSvn.cmake d57eed98285295bcc845bb0494c86e3866685690 



cmake ..


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message