mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.
Date Thu, 02 Mar 2017 23:14:04 GMT


> On Feb. 27, 2017, 10:25 p.m., Michael Park wrote:
> > src/master/master.hpp
> > Lines 2452-2461 (original), 2515-2524 (patched)
> > <https://reviews.apache.org/r/57110/diff/1/?file=1650787#file1650787line2536>
> >
> >     @bmahler: This allows even non-`MULTI_ROLE` frameworks to change their roles.
Is this meant to be supported?

Yeah I think we should support it, since it falls out naturally and is useful (we've been
asked for this several times and it's hard for a framework to change its role).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57110/#review166954
-----------------------------------------------------------


On Feb. 27, 2017, 10:19 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57110/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 10:19 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6627
>     https://issues.apache.org/jira/browse/MESOS-6627
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 764adb18ddf09b62529c5c96f8e4dfaf7803483e 
>   src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942 
> 
> 
> Diff: https://reviews.apache.org/r/57110/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message