mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 57190: Updated agent for hierarchical roles.
Date Thu, 02 Mar 2017 23:01:46 GMT


> On March 2, 2017, 11:12 p.m., Neil Conway wrote:
> > src/tests/role_tests.cpp
> > Lines 812 (patched)
> > <https://reviews.apache.org/r/57190/diff/1/?file=1652615#file1652615line812>
> >
> >     This might be better placed in `persistent_volume_tests.cpp`.

I was also drawn to implementing this as part of `PersistentVolumeTest`, but the test there
are largely occupied with testing persistent volumes and their interactions with different
disk volume types; the fixture expliclty requires any new tests to work on all tested types.
We otoh do not require any disk volumes here. I am unsure what other test case would be a
good fit.


> On March 2, 2017, 11:12 p.m., Neil Conway wrote:
> > src/tests/role_tests.cpp
> > Lines 887 (patched)
> > <https://reviews.apache.org/r/57190/diff/1/?file=1652615#file1652615line887>
> >
> >     We can't depend on `ls` and `grep` being available on Windows.
> >     
> >     We could write the test with `#ifdef`s, although that seems unfortunate. Not
sure there's a better alternative, given the current agent volume creation logic...

I'll see if this can be implemented with `test` and some globbing.


> On March 2, 2017, 11:12 p.m., Neil Conway wrote:
> > src/tests/role_tests.cpp
> > Lines 937 (patched)
> > <https://reviews.apache.org/r/57190/diff/1/?file=1652615#file1652615line937>
> >
> >     Do we really need the `v1` prefix to these variable names? Seems unnecessary.

That's a pattern copied from mainly `api_tests.cpp`. I agree it is less useful here.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57190/#review167297
-----------------------------------------------------------


On March 2, 2017, 6 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57190/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 6 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-7047
>     https://issues.apache.org/jira/browse/MESOS-7047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adjusts the way persistent volumes are stored on the
> agent. Instead of interpreting the role of the volume as a literal
> path, we replace `/` with ` ` when creating the path. This prevents
> that subdirectories are created for volumes with hierarchical roles.
> Directly interpreting the role as a path is undesirable as it can lead
> to volumes overlapping (e.g., a volume with role `a/b/c/d` and id `id`
> would be visible as `id` in a volume with role `a/b/c` and id `d`).
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.cpp 38ad1993aa36a627ec97a7865488677495ee4c5a 
>   src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 
> 
> 
> Diff: https://reviews.apache.org/r/57190/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message