mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57192: Updated WebUI to display role information under tab 'Frameworks'.
Date Thu, 02 Mar 2017 21:54:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57192/#review167747
-----------------------------------------------------------


Fix it, then Ship it!





src/webui/master/static/framework.html
Lines 26-27 (original), 26-27 (patched)
<https://reviews.apache.org/r/57192/#comment239676>

    Ditto from the previous review, a TODO for displaying this when there are a large number
of roles would be nice.



src/webui/master/static/frameworks.html
Line 47 (original), 47 (patched)
<https://reviews.apache.org/r/57192/#comment239677>

    Ditto from the previous review, a TODO for displaying this when there are a large number
of roles would be nice.



src/webui/master/static/frameworks.html
Line 105 (original), 105 (patched)
<https://reviews.apache.org/r/57192/#comment239678>

    Ditto from the previous review, a TODO for displaying this when there are a large number
of roles would be nice.



src/webui/master/static/frameworks.html
Line 154 (original), 154 (patched)
<https://reviews.apache.org/r/57192/#comment239679>

    Ditto from the previous review, a TODO for displaying this when there are a large number
of roles would be nice.



src/webui/master/static/js/controllers.js
Lines 180-182 (patched)
<https://reviews.apache.org/r/57192/#comment239674>

    How about a comment here since this seems a little subtle for those without context.



src/webui/master/static/js/controllers.js
Lines 242-244 (patched)
<https://reviews.apache.org/r/57192/#comment239675>

    Ditto here.


- Benjamin Mahler


On March 2, 2017, 3:34 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57192/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 3:34 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6657
>     https://issues.apache.org/jira/browse/MESOS-6657
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated WebUI to display role information under tab 'Frameworks'.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/framework.html 37e0b31ac90e877b70f315143b7411fadeeeeec6 
>   src/webui/master/static/frameworks.html 0c6fc1c37e0ab49fed64aaa861dfcbaab7f38e0e 
>   src/webui/master/static/js/controllers.js 2ea8275cb5fffa2344474ebfcf9277fe92165a92

> 
> 
> Diff: https://reviews.apache.org/r/57192/diff/2/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Tab Framework
>   https://reviews.apache.org/media/uploaded/files/2017/03/01/d8b4d962-7e0e-41d0-976c-2fbffb0dc3ad__Screen_Shot_2017-03-01_at_18.24.03.png
> Page Frameworks/Tasks
>   https://reviews.apache.org/media/uploaded/files/2017/03/01/e1a2340d-2817-4451-b70d-29b6e125c5a3__Screen_Shot_2017-03-01_at_18.28.17.png
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message