mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 57166: Updated role validation for hierarchical roles.
Date Thu, 02 Mar 2017 18:12:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57166/
-----------------------------------------------------------

(Updated March 2, 2017, 6:12 p.m.)


Review request for mesos, Benjamin Bannier and Michael Park.


Changes
-------

Address review comments.


Repository: mesos


Description
-------

Role names can now contain forward slashes. Each component in a role
name must now be validated separately.


Diffs (updated)
-----

  src/common/roles.cpp 31774a9b8f99f5efeed35b1c3e3486e05ca00f6a 
  src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 


Diff: https://reviews.apache.org/r/57166/diff/2/

Changes: https://reviews.apache.org/r/57166/diff/1-2/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message