mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57132: Fixed WebUI data-key.
Date Wed, 01 Mar 2017 18:56:22 GMT


> On March 1, 2017, 6:55 p.m., Benjamin Mahler wrote:
> > There are probably other `data-key`s that are broken too, I didn't do a sweep when
I had suggested fixing these :)

By the way, you can test if the data-key is correct by clicking the table headers and seeing
if it sorts in ascending vs descending order.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57132/#review167541
-----------------------------------------------------------


On March 1, 2017, 10:23 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57132/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 10:23 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6657
>     https://issues.apache.org/jira/browse/MESOS-6657
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some of the data-key are incorrect, which causes sorting problem.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/agent.html 7a4599367ea8ff802591adfd86d4058cdc51f297 
> 
> 
> Diff: https://reviews.apache.org/r/57132/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message