mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 53707: Added a Windows isolator. Removed `#ifdef`-ed block from Posix.
Date Wed, 01 Mar 2017 18:46:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53707/#review167530
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 5:45 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53707/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 5:45 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a  Windows isolator. Removed `#ifdef`-ed block from Posix.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 270d2aa6e06f323bfb6eee3b703a24a600a55871

>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 2bf011d3e7b014a17f759851d755b161c897b131

>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp f169c380f803a2111b1612cee60250ee9a30ef2e

> 
> 
> Diff: https://reviews.apache.org/r/53707/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message