mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 54769: Fixed a cleanup related bug in the IO switchboard.
Date Wed, 01 Mar 2017 18:45:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54769/#review167526
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Dec. 15, 2016, 2:03 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54769/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2016, 2:03 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6784
>     https://issues.apache.org/jira/browse/MESOS-6784
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, we never used to wait for `reaped()` to be executed
> completely before invoking `cleanup()`. This happened due to the
> fact that `reaped()` returned a `void` making the overload of
> `defer()` that just does `dispatch()` to the actor without
> waiting for `reaped()` to be complete.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.hpp 7a7ad2da047ef316f4382e45526d503c87a903a0

>   src/slave/containerizer/mesos/io/switchboard.cpp c80627986f729255e3b3ad1fc9cfa6213e19c521

> 
> 
> Diff: https://reviews.apache.org/r/54769/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fixed Test added later in the chain)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message