mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 50380: Added new benchmark test for port resources.
Date Wed, 01 Mar 2017 18:22:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50380/#review167405
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Oct. 18, 2016, 3:02 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50380/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2016, 3:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Klaus Ma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5898
>     https://issues.apache.org/jira/browse/MESOS-5898
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The current ports benchmark test is always using same port range,
> with port, the formula for `+` is `a+a+a+a+...+a==a`; for `-`,
> it will be `a-a=0` and `0-a=0`.
> 
> The fix is adding a new benchmark test for ports resources, using
> a initial and different range ports resources. This fix also
> removed the ports resources benchmark test from original resources
> benchmark test as we introduced a new test case for ports resources.
> 
> 
> Diffs
> -----
> 
>   src/tests/resources_tests.cpp 6a12783c26f359dda835b4866b299a8fcfb3f972 
> 
> 
> Diff: https://reviews.apache.org/r/50380/diff/7/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> ```
>  ./bin/mesos-tests.sh --benchmark --gtest_filter="Resources_Ports_BENCHMARK_Test.Arithmetic"
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from Resources_Ports_BENCHMARK_Test
> [ RUN      ] Resources_Ports_BENCHMARK_Test.Arithmetic
> Took 5.738039secs to perform 3000 'total -= r' operations on ports with 'total' as ports(*):[1-3000]
and 'r' as 'ports(*):[x-x]' where 'x' is from 1 to 3000
> Took 345315us to perform 3000 'total += r' operations on ports with 'total' as ports(*):[1-3000]
and 'r' as 'ports(*):[x-x]' where 'x' is from 1 to to 3000
> Took 6.098373secs to perform 3000 'total = total - r' operations on ports with 'total'
as ports(*):[1-3000] and 'r' as 'ports(*):[x-x]' where 'x' is from 1 to to 3000
> Took 715101us to perform 3000 'total = total + r' operations on ports with 'total' as
ports(*):[1-3000] and 'r' as 'ports(*):[x-x]' where 'x' is from 1 to to 3000
> [       OK ] Resources_Ports_BENCHMARK_Test.Arithmetic (12926 ms)
> [----------] 1 test from Resources_Ports_BENCHMARK_Test (12926 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (12940 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message