mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 50960: Added appc uri fetcher tests.
Date Wed, 01 Mar 2017 18:22:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50960/#review167398
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Oct. 16, 2016, 5:58 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50960/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2016, 5:58 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4288
>     https://issues.apache.org/jira/browse/MESOS-4288
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests to fetch using all three modes that 'rkt fetch' supports,
> fetch with meta discovery  ex: 'coreos.com/hello:latest',
> fetch from a specific  location ex: 'https://github.com/xxx/hello.aci'
> fetch from docker registry ex: 'docker://hello-world'.
> 
> 
> Diffs
> -----
> 
>   src/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b 
> 
> 
> Diff: https://reviews.apache.org/r/50960/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> Found issue that the tests would fail if "rkt" binary is not available. Please suggest
if I should use some environment variable to selectively run the tests under __IF_DEFINED_RKT
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message