mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 51157: Added testing for the container plugin of the CLI.
Date Wed, 01 Mar 2017 18:14:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51157/#review167367
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Aug. 16, 2016, 11:15 p.m., Haris Choudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51157/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2016, 11:15 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Kevin Klues.
> 
> 
> Bugs: mesos-5676
>     https://issues.apache.org/jira/browse/mesos-5676
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While introducing testing for the container plugin, some changes
> were made to the plugin methods themselves mainly to allow the return
> of stdout by methods that make use of nsenter is some way.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/bin/tests.py PRE-CREATION 
>   src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION 
>   src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/51157/diff/1/
> 
> 
> Testing
> -------
> 
> ![Tested on Ubuntu 14.04](http://i.imgur.com/Wo30SBw.png)
> 
> 
> Thanks,
> 
> Haris Choudhary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message