mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 50633: Libprocess: [1/3] Parameterized decoder tests for incremental parsing.
Date Wed, 01 Mar 2017 18:14:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50633/#review167352
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Aug. 2, 2016, 1:13 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50633/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 1:13 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-5943
>     https://issues.apache.org/jira/browse/MESOS-5943
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The parameter allows us to control how much data is fed to the parser
> per call.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/decoder_tests.cpp 4535614312373b0515025f09f9f8495f9ce353a3

> 
> 
> Diff: https://reviews.apache.org/r/50633/diff/2/
> 
> 
> Testing
> -------
> 
> The tests fail during incremental parsing of URLs. This is expected. The subsequent patches
fix these tests.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message