mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 47058: Fix accessibility of table in web GUI.
Date Wed, 01 Mar 2017 18:04:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47058/#review167311
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On May 8, 2016, 12:11 p.m., Chen Nan Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47058/
> -----------------------------------------------------------
> 
> (Updated May 8, 2016, 12:11 p.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
>     https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix accessibility of table in web GUI.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/browse.html 04a4600f0c762a2412ddee078ba2c173d595aa8d 
>   src/webui/master/static/framework.html 041513b0e005e8b54ca9723741b21b136ff61ca6 
>   src/webui/master/static/frameworks.html f172e022e18df5b6aa3d232e610c3c732e20aa09 
>   src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
>   src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
>   src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
>   src/webui/master/static/slave_executor.html 99b23ed9e85011a66bad780fb2d3076e946821a6

>   src/webui/master/static/slave_framework.html 176e7e9fa7878f31268bd5aa06dfc8789f3e7edd

>   src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 
> 
> 
> Diff: https://reviews.apache.org/r/47058/diff/3/
> 
> 
> Testing
> -------
> 
> We should use the scope attribute to associate header cells and data cells in data tables.
> 
> It can make screen readers to find a header of date cell in table.
> 
> for details refer to https://www.w3.org/TR/WCAG20-TECHS/H63.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message