From reviews-return-55157-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Feb 5 08:50:19 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D6C7E19997 for ; Sun, 5 Feb 2017 08:50:19 +0000 (UTC) Received: (qmail 18847 invoked by uid 500); 5 Feb 2017 08:50:19 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 18814 invoked by uid 500); 5 Feb 2017 08:50:19 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 18796 invoked by uid 99); 5 Feb 2017 08:50:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Feb 2017 08:50:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 088012CA8B4; Sun, 5 Feb 2017 08:50:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4199028693651081079==" MIME-Version: 1.0 Subject: Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX. From: Alex Clemmer To: Daniel Pravat , Joris Van Remoortere Cc: mesos , Michael Park , Alex Clemmer Date: Sun, 05 Feb 2017 08:50:19 -0000 Message-ID: <20170205085019.31774.62698@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alex Clemmer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54591/ X-Sender: Alex Clemmer References: <20170205013657.1722.56351@reviews.apache.org> In-Reply-To: <20170205013657.1722.56351@reviews.apache.org> X-ReviewBoard-Diff-For: 3rdparty/stout/include/stout/os/int_fd.hpp X-ReviewBoard-Diff-For: 3rdparty/stout/include/stout/os/windows/fd.hpp Reply-To: Alex Clemmer X-ReviewRequest-Repository: mesos --===============4199028693651081079== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/#review164276 ----------------------------------------------------------- 3rdparty/stout/include/stout/os.hpp (line 49) Oh, also, don't we need to add all of these headers to the `Makefile.am`? - Alex Clemmer On Feb. 5, 2017, 1:36 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54591/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2017, 1:36 a.m.) > > > Review request for mesos, Daniel Pravat and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > In POSIX the socket, pipe and a file are represented by the `int` type. > In Windows: > - A socket is kept in a `SOCKET` type (64 bit wide) > - A pipe or a WinAPI file descriptor in a `HANDLE` (64 bit wide) > - A CRT file descriptor in an `int` > > The `WindowsFD` class is a type that brings all of these things > together and behaves analogously to an `int` in POSIX. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 > 3rdparty/stout/include/stout/os/int_fd.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/fd.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54591/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > > --===============4199028693651081079==--