From reviews-return-55124-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Feb 4 17:51:17 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CE8F41988E for ; Sat, 4 Feb 2017 17:51:17 +0000 (UTC) Received: (qmail 22327 invoked by uid 500); 4 Feb 2017 17:51:12 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22295 invoked by uid 500); 4 Feb 2017 17:51:12 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22279 invoked by uid 99); 4 Feb 2017 17:51:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Feb 2017 17:51:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0F1162DF8A2; Sat, 4 Feb 2017 17:51:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6448957684459109632==" MIME-Version: 1.0 Subject: Re: Review Request 56269: Introduced a `Container` struct on the default executor. From: Anand Mazumdar To: Vinod Kone Cc: Anand Mazumdar , mesos Date: Sat, 04 Feb 2017 17:51:12 -0000 Message-ID: <20170204175112.1724.21494@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anand Mazumdar X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56269/ X-Sender: Anand Mazumdar References: <20170203044553.1722.52605@reviews.apache.org> In-Reply-To: <20170203044553.1722.52605@reviews.apache.org> Reply-To: Anand Mazumdar X-ReviewRequest-Repository: mesos --===============6448957684459109632== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56269/ ----------------------------------------------------------- (Updated Feb. 4, 2017, 5:51 p.m.) Review request for mesos and Vinod Kone. Changes ------- Review comments. Bugs: MESOS-6296 https://issues.apache.org/jira/browse/MESOS-6296 Repository: mesos Description ------- This helps us in consolidating various metadata associatd with an active child container. Also, this would be used in the future for figuring out the task group corresponding to a child container and then killing the other child containers belonging to the task group when one of the tasks fail; or if a task in the task group is explicitly killed by the scheduler. Diffs (updated) ----- src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3 Diff: https://reviews.apache.org/r/56269/diff/ Testing ------- make check Thanks, Anand Mazumdar --===============6448957684459109632==--