From reviews-return-55123-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Feb 4 17:49:07 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A2D0A1988A for ; Sat, 4 Feb 2017 17:49:07 +0000 (UTC) Received: (qmail 21762 invoked by uid 500); 4 Feb 2017 17:49:07 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 21726 invoked by uid 500); 4 Feb 2017 17:49:07 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 21710 invoked by uid 99); 4 Feb 2017 17:49:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Feb 2017 17:49:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 821ED2DF8A2; Sat, 4 Feb 2017 17:49:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1756399107658695603==" MIME-Version: 1.0 Subject: Review Request 56308: Modified active containers key to be `TaskID` in the default executor. From: Anand Mazumdar To: Vinod Kone Cc: Anand Mazumdar , mesos Date: Sat, 04 Feb 2017 17:49:06 -0000 Message-ID: <20170204174906.1724.21620@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anand Mazumdar X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56308/ X-Sender: Anand Mazumdar Reply-To: Anand Mazumdar X-ReviewRequest-Repository: mesos --===============1756399107658695603== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56308/ ----------------------------------------------------------- Review request for mesos and Vinod Kone. Bugs: MESOS-6296 https://issues.apache.org/jira/browse/MESOS-6296 Repository: mesos Description ------- We have more occurences of look up by `TaskID` then the other way around. Hence, modified the active containers hashmap to be keyed on `TaskID` instead. Diffs ----- src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3 Diff: https://reviews.apache.org/r/56308/diff/ Testing ------- make check Thanks, Anand Mazumdar --===============1756399107658695603==--