From reviews-return-55026-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Feb 3 06:56:34 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20F9D1904D for ; Fri, 3 Feb 2017 06:56:34 +0000 (UTC) Received: (qmail 31640 invoked by uid 500); 3 Feb 2017 06:56:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31606 invoked by uid 500); 3 Feb 2017 06:56:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31588 invoked by uid 99); 3 Feb 2017 06:56:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Feb 2017 06:56:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5A1C22C5B86; Fri, 3 Feb 2017 06:56:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0028008249673532119==" MIME-Version: 1.0 Subject: Re: Review Request 56270: Made the default executor launch multiple task groups. From: Mesos Reviewbot To: Vinod Kone Cc: Mesos Reviewbot , Anand Mazumdar , mesos Date: Fri, 03 Feb 2017 06:56:28 -0000 Message-ID: <20170203065628.1722.21365@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56270/ X-Sender: Mesos Reviewbot References: <20170203044558.1722.3110@reviews.apache.org> In-Reply-To: <20170203044558.1722.3110@reviews.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============0028008249673532119== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56270/#review164094 ----------------------------------------------------------- Patch looks great! Reviews applied: [56267, 56268, 56269, 56270] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 3, 2017, 4:45 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56270/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2017, 4:45 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6296 > https://issues.apache.org/jira/browse/MESOS-6296 > > > Repository: mesos > > > Description > ------- > > If a task fails or is explicitly killed by the scheduler, the > default on termination policy kills the particular task group. > The executor commits suicide when there are no active tasks. > > > Diffs > ----- > > src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3 > src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659 > > Diff: https://reviews.apache.org/r/56270/diff/ > > > Testing > ------- > > make check. Also, modified an existing test to launch/kill multiple task groups. > > > Thanks, > > Anand Mazumdar > > --===============0028008249673532119==--