mesos-reviews mailing list archives: February 2017

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · 11 · 12 · 13 · 14 · 15 · 16 · 17 · Next »Thread · Author · Date
Mesos Reviewbot Re: Review Request 57112: Updated existing test cases to allow for frameworks to change its roles. Tue, 28 Feb, 01:44
Mesos Reviewbot Re: Review Request 56906: Dealt with a corner case in the ReadFile API. Tue, 28 Feb, 03:32
Mesos Reviewbot Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents. Tue, 28 Feb, 05:27
Mesos Reviewbot Re: Review Request 57118: Added debugging APIs to agent API docs. Tue, 28 Feb, 10:50
Mesos Reviewbot Re: Review Request 56195: Fixed ContainerLogger / IOSwitchboard FD leaks. Tue, 28 Feb, 13:10
Mesos Reviewbot Re: Review Request 56611: Relax perf version check for Arch Linux. Tue, 28 Feb, 15:01
Mesos Reviewbot Re: Review Request 57132: Updated WebUI to display roles. Tue, 28 Feb, 22:34
Michael Park Re: Review Request 55971: Updated the agent to be MULTI_ROLE capable. Wed, 01 Feb, 21:01
Michael Park Re: Review Request 55971: Updated the agent to be MULTI_ROLE capable. Wed, 01 Feb, 21:01
Michael Park Re: Review Request 56006: Added CHECK logging to the allocator. Wed, 01 Feb, 21:03
Michael Park Re: Review Request 56004: Fixed MULTI_ROLE related bugs when updating framework info. Wed, 01 Feb, 23:38
Michael Park Re: Review Request 55972: Updated master to handle non-MULTI_ROLE agents. Wed, 01 Feb, 23:55
Michael Park Re: Review Request 55973: Update the tests to handle MULTI_ROLE support. Thu, 02 Feb, 06:01
Michael Park Re: Review Request 55732: Added `--3way` option to apply-reviews.py. Thu, 02 Feb, 22:26
Michael Park Re: Review Request 56245: Fixed typos in name of test suite. Fri, 03 Feb, 23:56
Michael Park Re: Review Request 56246: Fixed typos. Fri, 03 Feb, 23:58
Michael Park Re: Review Request 56247: Switched to implicit roles in master quota tests. Sat, 04 Feb, 00:09
Michael Park Re: Review Request 56248: Replaced use of ".get()" in master quota tests with "->". Sat, 04 Feb, 00:20
Michael Park Re: Review Request 56249: Cleaned up code style slightly in DRF sorter. Sat, 04 Feb, 00:24
Michael Park Re: Review Request 56250: Cleaned up headers in sorter and allocator metrics. Sat, 04 Feb, 00:26
Michael Park Re: Review Request 56251: Tightened assertions in sorter and allocator. Sat, 04 Feb, 20:48
Michael Park Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX. Sun, 05 Feb, 01:36
Michael Park Re: Review Request 54595: Introduced an `os::dup` abstraction in stout. Sun, 05 Feb, 01:38
Michael Park Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout. Sun, 05 Feb, 01:38
Michael Park Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout. Sun, 05 Feb, 01:38
Michael Park Re: Review Request 54601: Replaced `int` with `int_fd` in stout. Sun, 05 Feb, 01:39
Michael Park Re: Review Request 54602: Replaced `int` with `int_fd` in libprocess. Sun, 05 Feb, 01:39
Michael Park Re: Review Request 54603: Replaced `int` with `int_fd` in mesos. Sun, 05 Feb, 01:39
Michael Park Re: Review Request 54601: Replaced `int` with `int_fd` in stout. Sun, 05 Feb, 07:11
Michael Park Re: Review Request 54602: Replaced `int` with `int_fd` in libprocess. Sun, 05 Feb, 07:12
Michael Park Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX. Sun, 05 Feb, 21:24
Michael Park Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX. Mon, 06 Feb, 01:04
Michael Park Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX. Mon, 06 Feb, 01:04
Michael Park Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX. Mon, 06 Feb, 01:59
Michael Park Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX. Mon, 06 Feb, 02:02
Michael Park Re: Review Request 54595: Introduced an `os::dup` abstraction in stout. Mon, 06 Feb, 02:14
Michael Park Re: Review Request 54595: Introduced an `os::dup` abstraction in stout. Mon, 06 Feb, 02:15
Michael Park Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout. Mon, 06 Feb, 02:20
Michael Park Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout. Mon, 06 Feb, 02:21
Michael Park Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout. Mon, 06 Feb, 02:27
Michael Park Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`. Mon, 06 Feb, 23:22
Michael Park Re: Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`. Mon, 06 Feb, 23:23
Michael Park Re: Review Request 56247: Switched to implicit roles in master quota tests. Wed, 08 Feb, 00:22
Michael Park Re: Review Request 56349: Clarified comments in sorter. Wed, 08 Feb, 00:51
Michael Park Re: Review Request 56350: Const-ified several methods in the sorter interface. Wed, 08 Feb, 00:52
Michael Park Re: Review Request 56351: Renamed a private member function in DRFSorter. Wed, 08 Feb, 00:52
Michael Park Re: Review Request 56421: Added TODOs to make the agent code safer. Wed, 08 Feb, 22:14
Michael Park Re: Review Request 56422: Inject resource allocation info in agent for received tasks. Wed, 08 Feb, 22:54
Michael Park Re: Review Request 56423: Added CHECKs to the agent to ensure allocation info is set. Wed, 08 Feb, 22:56
Michael Park Re: Review Request 56424: Removed a stale TODO in the agent code. Wed, 08 Feb, 22:57
Michael Park Re: Review Request 55710: Added agent capabilities to /state endpoint of master. Wed, 08 Feb, 23:46
Michael Park Re: Review Request 56375: Added a test to ensure offers with different roles cannot be combined. Thu, 09 Feb, 00:00
Michael Park Re: Review Request 56360: Fixed consistency in error messages. Thu, 09 Feb, 00:01
Michael Park Re: Review Request 56370: Added a test to ensure multi-role framework receiving offers. Thu, 09 Feb, 00:18
Michael Park Re: Review Request 56427: Added another sorter test case. Thu, 09 Feb, 00:46
Michael Park Re: Review Request 55710: Added agent capabilities to /state endpoint of master. Thu, 09 Feb, 09:27
Michael Park Review Request 56781: Fixed compilation on VS 2017. Fri, 17 Feb, 08:12
Michael Park Re: Review Request 56781: Fixed compilation on VS 2017. Fri, 17 Feb, 20:07
Michael Park Re: Review Request 56692: Silenced a GMock warning in a test. Fri, 17 Feb, 20:09
Michael Park Review Request 57104: Updated a few functions in the agent to be declared `const`. Mon, 27 Feb, 21:57
Michael Park Review Request 57105: Updated a few functions in the master to be declared `const`. Mon, 27 Feb, 21:57
Michael Park Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`. Mon, 27 Feb, 22:11
Michael Park Review Request 57108: Handled the `FrameworkInfo` field added to the `UpdateFrameworkMessage`. Mon, 27 Feb, 22:12
Michael Park Re: Review Request 57108: Handled the `FrameworkInfo` field added to the `UpdateFrameworkMessage`. Mon, 27 Feb, 22:15
Michael Park Review Request 57109: Re-checkpointed the `Executor`s and `Task`s during agent recovery. Mon, 27 Feb, 22:18
Michael Park Review Request 57110: Updated the master to handle frameworks that changes its roles. Mon, 27 Feb, 22:19
Michael Park Review Request 57111: Updated the allocator to handle frameworks that change its roles. Mon, 27 Feb, 22:20
Michael Park Review Request 57112: Updated existing test cases to allow for frameworks to change its roles. Mon, 27 Feb, 22:20
Michael Park Re: Review Request 57110: Updated the master to handle frameworks that changes its roles. Mon, 27 Feb, 22:25
Michael Park Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles. Mon, 27 Feb, 22:30
Michael Park Re: Review Request 56806: Fixed some clang-tidy warnings. Tue, 28 Feb, 19:17
Michael Park Re: Review Request 57157: Cleaned up `using` statements. Tue, 28 Feb, 19:17
Neil Conway Re: Review Request 56177: Updated reconciliation comment in "scheduler.proto". Wed, 01 Feb, 17:34
Neil Conway Review Request 56245: Fixed typos in name of test suite. Thu, 02 Feb, 22:58
Neil Conway Review Request 56246: Fixed typos. Thu, 02 Feb, 22:59
Neil Conway Review Request 56247: Switched to implicit roles in master quota tests. Thu, 02 Feb, 22:59
Neil Conway Review Request 56248: Replaced use of ".get()" in master quota tests with "->". Thu, 02 Feb, 22:59
Neil Conway Review Request 56249: Cleaned up code style slightly in DRF sorter. Thu, 02 Feb, 22:59
Neil Conway Review Request 56250: Cleaned up headers in DRF sorter. Thu, 02 Feb, 22:59
Neil Conway Review Request 56251: Tightened assertions in sorter and allocator. Thu, 02 Feb, 22:59
Neil Conway Re: Review Request 56251: Tightened assertions in sorter and allocator. Fri, 03 Feb, 17:57
Neil Conway Re: Review Request 56250: Cleaned up headers in sorter and allocator metrics. Fri, 03 Feb, 20:21
Neil Conway Re: Review Request 56251: Tightened assertions in sorter and allocator. Sat, 04 Feb, 00:22
Neil Conway Re: Review Request 56247: Switched to implicit roles in master quota tests. Sun, 05 Feb, 21:35
Neil Conway Re: Review Request 56249: Cleaned up code style slightly in DRF sorter. Sun, 05 Feb, 22:01
Neil Conway Review Request 56349: Clarified comments in sorter. Mon, 06 Feb, 23:10
Neil Conway Review Request 56350: Const-ified several methods in the sorter interface. Mon, 06 Feb, 23:13
Neil Conway Review Request 56351: Renamed a private member function in DRFSorter. Mon, 06 Feb, 23:14
Neil Conway Review Request 56352: Optimized and simplified `DRFSorter::allocated()`. Mon, 06 Feb, 23:16
Neil Conway Re: Review Request 56352: Optimized and simplified `DRFSorter::allocated()`. Mon, 06 Feb, 23:21
Neil Conway Re: Review Request 56350: Const-ified several methods in the sorter interface. Tue, 07 Feb, 22:39
Neil Conway Re: Review Request 56350: Const-ified several methods in the sorter interface. Tue, 07 Feb, 22:58
Neil Conway Review Request 56427: Added another sorter test case. Wed, 08 Feb, 03:40
Neil Conway Re: Review Request 56427: Added another sorter test case. Thu, 09 Feb, 00:47
Neil Conway Re: Review Request 53993: Updated quota doc to support quota update. Thu, 09 Feb, 17:41
Neil Conway Re: Review Request 53993: Updated quota doc to support quota update. Thu, 09 Feb, 21:50
Neil Conway Re: Review Request 56611: Relax perf version check for Arch Linux. Mon, 13 Feb, 23:17
Neil Conway Review Request 56692: Silenced a GMock warning in a test. Wed, 15 Feb, 00:05
Neil Conway Re: Review Request 56692: Silenced a GMock warning in a test. Fri, 17 Feb, 19:35
Neil Conway Re: Review Request 56611: Relax perf version check for Arch Linux. Fri, 17 Feb, 22:06
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · 11 · 12 · 13 · 14 · 15 · 16 · 17 · Next »Thread · Author · Date
Box list
Oct 202122
Sep 202135
Aug 202118
Jul 202145
Jun 2021122
May 2021118
Apr 20215
Mar 20214
Feb 20215
Jan 202144
Dec 202017
Nov 202011
Oct 202050
Sep 2020188
Aug 2020388
Jul 2020125
Jun 202033
May 2020154
Apr 2020285
Mar 2020342
Feb 2020191
Jan 2020303
Dec 2019159
Nov 2019239
Oct 2019162
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338