mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56939: Added allocation role validation for ExecutorInfo.
Date Fri, 24 Feb 2017 22:12:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56939/#review166749
-----------------------------------------------------------


Fix it, then Ship it!





src/master/validation.cpp (lines 587 - 610)
<https://reviews.apache.org/r/56939/#comment238787>

    How about we validate that it's allocated, and it's allocated to 1 role, so something
like `validateAllocatedToSingleRole`.



src/master/validation.cpp (lines 602 - 604)
<https://reviews.apache.org/r/56939/#comment238781>

    We try to open and close quotes on the same line, since when on different lines we sometimes
forget to close them. E.g. 
    
    ```
    "The resources have multiple allocation roles ('" + _role + "'"
    " and '" + role.get() + "') but only one allocation role" +
    " is allowed");
    ```
    
    or:
    
    ```
    "The resources have multiple allocation roles"
    " ('" + _role + "' and '" + role.get() + "')"
    " but only one allocation role is allowed");
    ```



src/tests/master_validation_tests.cpp (line 2230)
<https://reviews.apache.org/r/56939/#comment238786>

    We should also test the case where the executor has unallocated resources, which is not
allowed since the master ensures the allocation info is injected. At this point, maybe a different
test name, like `ExecutorInfoAllocatedResources`.



src/tests/master_validation_tests.cpp (lines 2235 - 2236)
<https://reviews.apache.org/r/56939/#comment238838>

    Hm.. we should probably just pull this test out into its own scope?


- Benjamin Mahler


On Feb. 24, 2017, 10:48 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56939/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2017, 10:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael
Park.
> 
> 
> Bugs: MESOS-6636
>     https://issues.apache.org/jira/browse/MESOS-6636
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With support for multi-role frameworks, we need to make sure that
> individual executors cannot mix allocation roles.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19 
>   src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f 
>   src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31 
> 
> Diff: https://reviews.apache.org/r/56939/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message