mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56938: Added allocation role to tasks/executors in v0 /state API.
Date Wed, 22 Feb 2017 19:46:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56938/#review166402
-----------------------------------------------------------



This needs to update the following as well:
https://github.com/apache/mesos/blob/807b2343fac186d4fe5f42362c07a729fcaad80f/src/slave/http.cpp#L123-L139


src/common/http.cpp (lines 562 - 567)
<https://reviews.apache.org/r/56938/#comment238322>

    A comment on this condition would be good. When is an executor with 0 resources allowed?
Is this possible for any executor, or just the command executor?


- Benjamin Mahler


On Feb. 22, 2017, 5:49 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56938/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2017, 5:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael
Park.
> 
> 
> Bugs: MESOS-7158
>     https://issues.apache.org/jira/browse/MESOS-7158
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added allocation role of tasks/executors to the /state v0 API. Unlike
> v1 API where allocation_info is nested in each one of resources, we
> add that information at task/executor level for v0 API for the sake
> of simplicity. Note that resources of one task/executor are guaranteed
> to have same allocation role.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp abfbf7248beb2d4068be06b7f5f829d7617f943e 
>   src/master/http.cpp e2fd71c5ae4178564b9a08756df5175aec5d6ca1 
> 
> Diff: https://reviews.apache.org/r/56938/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message