mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56375: Added a test to ensure offers with different roles cannot be combined.
Date Tue, 21 Feb 2017 23:57:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56375/#review166271
-----------------------------------------------------------


Ship it!





src/tests/master_tests.cpp (lines 1885 - 1902)
<https://reviews.apache.org/r/56375/#comment238186>

    Made some slight adjustments here:
    
    ```
    // This test ensures that a multi-role framework cannot launch tasks with
    // offers allocated to different roles of that framework in a single
    // launchTasks call. We follow similar pattern in LaunchCombinedOfferTest.
    //
    // We launch a cluster with one master and one slave, and a framework
    // with two roles. Firstly, total resources will be offered to one of
    // the roles (we don't assume that it is deterministic as to which of
    // the two roles are chosen first). We launch a task using half of the
    // total resources. The other half will be returned to master and offered
    // to the other role, since it has a lower share (0). Then we kill the
    // task, half of resources will be offered to first role again, since
    // the first has a lower share (0). At this point, two offers with
    // different roles are outstanding and we can combine them in one
    // `launchTasks` call. A non-partition-aware framework should
    // receive TASK_LOST.
    ```


- Benjamin Mahler


On Feb. 20, 2017, 7:35 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56375/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2017, 7:35 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
> 
> 
> Bugs: MESOS-6637
>     https://issues.apache.org/jira/browse/MESOS-6637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Multi-role framework cannot combine offers allocated to different
> roles of that framework in a single launchTask call.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 64443dc6e2ca4ab8f37269a0dced49908526649b 
> 
> Diff: https://reviews.apache.org/r/56375/diff/
> 
> 
> Testing
> -------
> 
> Added a test
> make check GTEST_FILTER="MasterTest.LaunchDifferentRoleLost"
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message