mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <>
Subject Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.
Date Tue, 21 Feb 2017 07:20:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 21, 2017, 7:20 a.m.)

Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.


Addressed review comments.

Bugs: MESOS-6953

Repository: mesos

Description (updated)

Added support for action `run_tasks` on the agent's flag `acl`. Based on
the ACL configured for `run_tasks`, a task to be launched on the agent
can be (dis)allowed to launch on the agent.
If a task or task group cannot be launched due to failed authorization,
a `TASK_FAILED` Status Update shall be sent with a reason code of
Note that in case of a task group, all tasks fail if any of the tasks
within the task group encounter the authorization error.

Diffs (updated)

  src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2 
  src/slave/slave.cpp 7564e8d39530794131dbbc928fcbc59fb65ef471 
  src/tests/master_slave_reconciliation_tests.cpp 1c7a3d686e2f924ad14c75fcab2ccafaab6d7b81

  src/tests/mock_slave.hpp 1acb961b642e1e0b4677db7b8fc6150d480eb751 
  src/tests/mock_slave.cpp 50c04bff9e6f0f202af4c07b4036e021d3833ebf 
  src/tests/slave_tests.cpp 16bb14b170d724bd8424778a76de28b0efccc6ed 



All tests passed.


Anindya Sinha

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message