mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 54783: Adds authorization tests of launching container sessions API.
Date Tue, 21 Feb 2017 04:06:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54783/#review166120
-----------------------------------------------------------


Ship it!




Looks like a fine test of unauthorized access. Authorized access is tested by `AgentAPITest.LaunchNestedContainerSession`

- Adam B


On Feb. 15, 2017, 6:30 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54783/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2017, 6:30 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-6886
>     https://issues.apache.org/jira/browse/MESOS-6886
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduces a test which ensures that unauthorized users are unable to
> launch nested container sessions.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f 
> 
> Diff: https://reviews.apache.org/r/54783/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message