mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@apache.org>
Subject Re: Review Request 51053: Update leveldb to 1.19.
Date Mon, 20 Feb 2017 15:26:17 GMT


> On Aug. 22, 2016, 2:29 a.m., Vinod Kone wrote:
> > Have you also done compatibility tests mentioned in the ticket?
> 
> Tomasz Janiszewski wrote:
>     No. It's minior upgrade from 1.18 to 1.19 but I can got thur https://docs.google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit#
and check if everything is OK.
> 
> haosdent huang wrote:
>     I could help to run from 1.14 to 1.19 if it is necessary. :)
> 
> Tomasz Janiszewski wrote:
>     I took care of it. Folloed steps presented by Haosdent it works the same. Benchamrks
were run as presented in ticket comments `MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK*.*/1"
make check`. All tests performed on Ubuntu 16.04 4.4.0-34-generic x86_64.
>     I've got a problem with running `support/test-upgrade.py` it failed with `mesos 1.0.0
framework failed` framework output ends with `Registered!`
> 
> haosdent huang wrote:
>     As I test, `support/test-upgrade.py` requires pass all path with absolute paths,
otherwise would get 
>     
>     ```
>     sh: ./mesos_1.4/build/src/test-executor: No such file or directory
>     ```
>     
>     in stderr of tasks.
>     
>     After use absolute paths as the parameters of `support/test-upgrade.py`, everything
works fine.
> 
> Alexander Rojas wrote:
>     This patch managed to break the build in OS-X. On a first run it will break with
the following message:
>     
>     ```
>     checking if clang supports -c -o file.o... yes
>     checking for poll.h... yes
>     checking sys/select.h usability... checking if clang supports -fno-rtti -fno-exceptions...
yes
>     checking if clang supports -c -o file.o... yes
>     (cached) yes
>     checking for clang option to produce PIC... checking whether the clang linker (/usr/bin/ld)
supports shared libraries... -fno-common -DPIC
>     checking if clang PIC flag -fno-common -DPIC works... yes
>     checking dynamic linker characteristics... mkdir out-shared
>     clang++ -stdlib=libc++ -nostdinc++ -I/usr/local/opt/llvm@3.8/lib/llvm-3.8/include/c++/v1
-Wno-deprecated-declarations  -fvisibility-inlines-hidden -fcolor-diagnostics -Wno-unused-local-typedef
-std=c++11 -stdlib=libc++ -DGTEST_USE_OWN_TR1
>     _TUPLE=1 -DGTEST_LANG_CXX11 -I. -I./include -std=c++0x  -DOS_MACOSX -DLEVELDB_PLATFORM_POSIX
-DLEVELDB_ATOMIC_PRESENT -stdlib=libc++ -nostdinc++ -I/usr/local/opt/llvm@3.8/lib/llvm-3.8/include/c++/v1
-Wno-deprecated-declarations  -fvisibil
>     ity-inlines-hidden -fcolor-diagnostics -Wno-unused-local-typedef -std=c++11 -stdlib=libc++
-DGTEST_USE_OWN_TR1_TUPLE=1 -DGTEST_LANG_CXX11 -fPIC -fPIC -c db/db_bench.cc -o out-shared/db/db_bench.o
>     yes
>     checking sys/select.h presence... error: unable to open output file 'out-shared/db/db_bench.o':
'No such file or directory'
>     1 error generated.
>     make[4]: *** [out-shared/db/db_bench.o] Error 1
>     make[3]: *** [leveldb-1.19/out-static/libleveldb.a] Error 2
>     make[3]: *** Waiting for unfinished jobs....
>     ```
>     
>     if one re-runs the make command, then it fails with the following error:
>     
>     ```
>     clang -I. -I./include -DOS_MACOSX -DLEVELDB_PLATFORM_POSIX -DLEVELDB_ATOMIC_PRESENT
-stdlib=libc++ -nostdinc++ -I/usr/local/opt/llvm@3.8/lib/llvm-3.8/include/c++/v1 -Wno-deprecated-declarations
 -fvisibility-inlines-hidden -fcolor-diagnostics -Wno-unused-local-typedef -std=c++11 -stdlib=libc++
-DGTEST_USE_OWN_TR1_TUPLE=1 -DGTEST_LANG_CXX11 -fPIC -c db/c_test.c -o out-static/db/c_test.o
>     error: invalid argument '-std=c++11' not allowed with 'C/ObjC'
>     ```
>     
>     This one indicates that the C compiler is using `CXXFLAGS` instead of `CFLAGS` or
that `CFLAGS` are being wrongly generated. Running a thir time the make command throes the
following output:
>     
>     ```
>     clang -I. -I./include -DOS_MACOSX -DLEVELDB_PLATFORM_POSIX -DLEVELDB_ATOMIC_PRESENT
-stdlib=libc++ -nostdinc++ -I/usr/local/opt/llvm@3.8/lib/llvm-3.8/include/c++/v1 -Wno-deprecated-declarations
 -fvisibility-inlines-hidden -fcolor-diagno$
>     tics -Wno-unused-local-typedef -std=c++11 -stdlib=libc++ -DGTEST_USE_OWN_TR1_TUPLE=1
-DGTEST_LANG_CXX11 -fPIC -c db/c_test.c -o out-static/db/c_test.o
>     clang++ -L/usr/local/opt/subversion/lib -L/usr/local/opt/openssl/lib -L/usr/local/opt/libevent/lib
-L/usr/local/opt/apr/libexec/lib -L/usr/local/opt/llvm/lib -Wl,-rpath,/usr/local/opt/llvm/lib
 -fcolor-diagnostics  -stdlib=libc++ -nostdi$
>     c++ -I/usr/local/opt/llvm@3.8/lib/llvm-3.8/include/c++/v1 -Wno-deprecated-declarations
 -fvisibility-inlines-hidden -fcolor-diagnostics -Wno-unused-local-typedef -std=c++11 -stdlib=libc++
-DGTEST_USE_OWN_TR1_TUPLE=1 -DGTEST_LANG_CXX11 -I$
>      -I./include -std=c++0x  -DOS_MACOSX -DLEVELDB_PLATFORM_POSIX -DLEVELDB_ATOMIC_PRESENT
-stdlib=libc++ -nostdinc++ -I/usr/local/opt/llvm@3.8/lib/llvm-3.8/include/c++/v1 -Wno-deprecated-declarations
 -fvisibility-inlines-hidden -fcolor-dia$
>     nostics -Wno-unused-local-typedef -std=c++11 -stdlib=libc++ -DGTEST_USE_OWN_TR1_TUPLE=1
-DGTEST_LANG_CXX11 -fPIC db/corruption_test.cc out-static/db/builder.o out-static/db/c.o out-static/db/db_impl.o
out-static/db/db_iter.o out-static/d$
>     /dbformat.o out-static/db/dumpfile.o out-static/db/filename.o out-static/db/log_reader.o
out-static/db/log_writer.o out-static/db/memtable.o out-static/db/repair.o out-static/db/table_cache.o
out-static/db/version_edit.o out-static/db/ve$
>     sion_set.o out-static/db/write_batch.o out-static/table/block.o out-static/table/block_builder.o
out-static/table/filter_block.o out-static/table/format.o out-static/table/iterator.o out-static/table/merger.o
out-static/table/table.o out$
>     static/table/table_builder.o out-static/table/two_level_iterator.o out-static/util/arena.o
out-static/util/bloom.o out-static/util/cache.o out-static/util/coding.o out-static/util/comparator.o
out-static/util/crc32c.o out-static/util/env$
>     o out-static/util/env_posix.o out-static/util/filter_policy.o out-static/util/hash.o
out-static/util/histogram.o out-static/util/logging.o out-static/util/options.o out-static/util/status.o
out-static/port/port_posix.o out-static/util/tes
>     tharness.o out-static/util/testutil.o -o out-static/corruption_test
>     error: invalid argument '-std=c++11' not allowed with 'C/ObjC'
>     make[4]: *** [out-static/db/c_test.o] Error 1
>     make[4]: *** Waiting for unfinished jobs....
>     make[3]: *** [leveldb-1.19/out-static/libleveldb.a] Error 2
>     make[2]: *** [check-recursive] Error 1
>     make[1]: *** [check] Error 2
>     make: *** [check-recursive] Error 1
>     ```
>     
>     persisting pays off however, and it finally manages to build Mesos.

There is a follow up patch to disable dbbench. Let me check if it fix the problem.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51053/#review146280
-----------------------------------------------------------


On Feb. 20, 2017, 4:41 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51053/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2017, 4:41 a.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and
Vinod Kone.
> 
> 
> Bugs: MESOS-970
>     https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Leveldb in modern version is required to support s390x and arm64.
> It's also required to replace default byte-wise comparator
> with varint comparator in \`src/log/leveldb.cpp\`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am bbf9cfe7125b193003115f440a00c91e2e68f404 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8

>   3rdparty/cmake/Versions.cmake ad23f3895b49d623709c0939d63a0529654788ef 
>   3rdparty/leveldb-1.19.patch PRE-CREATION 
>   3rdparty/leveldb-1.19.tar.gz PRE-CREATION 
>   3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
>   3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
>   3rdparty/versions.am 26f839cd8d454de91f10c2e616e78decc30eff1b 
>   LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a 
>   src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
>   src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5

> 
> Diff: https://reviews.apache.org/r/51053/diff/
> 
> 
> Testing
> -------
> 
> make -j 8 distcheck
> 
> Test document: https://docs.google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit?usp=sharing
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message