mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 56732: Remove unnecessary perf version checks.
Date Wed, 15 Feb 2017 23:22:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56732/
-----------------------------------------------------------

Review request for mesos, Mesos Reviewbot and Jiang Yan Xu.


Bugs: MESOS-7049
    https://issues.apache.org/jira/browse/MESOS-7049


Repository: mesos


Description
-------

We can remove the version check from the perf subprocess
wrapper because we longer uses the version to figure out
how to parse the stat output and the callers explicitly
check perf::supported().


Diffs
-----

  src/linux/perf.hpp 9c4330b6086abb18f036222260fe89a6fb01d8ed 
  src/linux/perf.cpp 3141e5ee9eee78e974625791f362dc345c682ebb 
  src/tests/containerizer/perf_tests.cpp d536ecc5cb24787bc3487efb146573cd4f3ded43 

Diff: https://reviews.apache.org/r/56732/diff/


Testing
-------

sudo make check (Fedora 25)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message