mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 56716: Fixed a crash on the default executor due to a failed invariant check.
Date Wed, 15 Feb 2017 21:36:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56716/#review165762
-----------------------------------------------------------



Patch looks great!

Reviews applied: [56716]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 15, 2017, 6:28 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56716/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2017, 6:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7129
>     https://issues.apache.org/jira/browse/MESOS-7129
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There was an incorrect assumption when kiling a task group that
> all its other tasks would still be active. Its possible that
> some of them terminated successfully earlier.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a 
>   src/tests/default_executor_tests.cpp 1afab8292c7fc15bd16bee4bcd93ce290a233c9a 
> 
> Diff: https://reviews.apache.org/r/56716/diff/
> 
> 
> Testing
> -------
> 
> make check + added test
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message