mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.
Date Wed, 15 Feb 2017 21:17:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56721/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-4945
    https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
-------

This includes the following changes:
- add a `pruneImages()` function on the chain of relevant classes;
- implement prune in docker store;
- fix mock interface to keep existing tests pass.


Diffs
-----

  src/slave/containerizer/composing.hpp 292374aefbc70e4b9d8c81740656864dbada8e32 
  src/slave/containerizer/composing.cpp 46539e4671101f9c51de563f52700e974537b472 
  src/slave/containerizer/containerizer.hpp f65a9b9761fc254bd0778bf13aac9b256497b22f 
  src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3 
  src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d 
  src/slave/containerizer/mesos/containerizer.hpp 10a9b57660388ac2409458a4d07af64cc3b185e2

  src/slave/containerizer/mesos/containerizer.cpp d2b4f75a55dbe4746bc2dfc180335fa831a554ef

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab

  src/slave/containerizer/mesos/provisioner/docker/paths.hpp 232c027f8f96da0cb30b957bce4607d3695050d2

  src/slave/containerizer/mesos/provisioner/docker/paths.cpp cd684b33eb308ce1eeb4539a5b2d51985d835db7

  src/slave/containerizer/mesos/provisioner/docker/store.hpp e1abff19c8877ad07900bb2f44deca1cdda41f58

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2

  src/slave/containerizer/mesos/provisioner/provisioner.hpp ff52e35ac44fea70fe2031e6ac537c613c57f50f

  src/slave/containerizer/mesos/provisioner/provisioner.cpp 8c20d4077859d437999467d045dfd500c1e576dd

  src/slave/containerizer/mesos/provisioner/store.hpp 82a9be64264ae829773c1e2e8a4360f78641cbf6

  src/slave/containerizer/mesos/provisioner/store.cpp 7141d63fcf2dbc3fbf00508c7f92945aab014fb2

  src/tests/containerizer.hpp 63fe2366d5fe79c71cbe62813a9bb0b830e70057 
  src/tests/containerizer.cpp 548da3a8757c9ad3ab115c6b91f8a1f2f5e37144 
  src/tests/containerizer/mock_containerizer.hpp ca0ae053b1eed01d6c04f581cd08485beec0c5fb


Diff: https://reviews.apache.org/r/56721/diff/


Testing
-------


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message