mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 56217: Added support for general checks to default executor.
Date Wed, 15 Feb 2017 14:32:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56217/#review165698
-----------------------------------------------------------




src/launcher/default_executor.cpp (line 93)
<https://reviews.apache.org/r/56217/#comment237560>

    `s/for a/for the/` to be consistent with the other comments.



src/launcher/default_executor.cpp (line 931)
<https://reviews.apache.org/r/56217/#comment237563>

    I think that it'd be useful to also log the exit status/http status code.
    
    Maybe the best way would be to implement the `ostream::operator<<` for `CheckStatusInfo`?


- Gastón Kleiman


On Feb. 8, 2017, 4:57 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56217/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 4:57 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a 
> 
> Diff: https://reviews.apache.org/r/56217/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56218/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message