mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 56702: Windows: Handle environment variable inheritance uniformly in Mesos.
Date Wed, 15 Feb 2017 12:30:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56702/#review165689
-----------------------------------------------------------



Patch looks great!

Reviews applied: [55022, 55023, 55024, 55030, 55162, 55543, 55546, 55547, 55549, 55550, 55749,
56504, 56505, 56702]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 15, 2017, 10:58 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56702/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2017, 10:58 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This review is a planned regression on MESOS-6816. In other parts of the
> codebase, we copy all environment variables from the system before
> launching a process, overwriting user specified environment variables.
> 
> This is not correct behavior, but a half-measure that is necessary,
> because Windows does not inherit environment variables by default. In
> this commit, we make this behavior uniform across all places where we
> are creating a process, because it is better for behavior to be
> consistent before we get around to fixing it. We do have concrete plans
> to come back and resolve this issue.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d 
>   src/slave/containerizer/mesos/launch.cpp 4dd81b47ca4654f5e783a4f2227834e938bc8bb3 
> 
> Diff: https://reviews.apache.org/r/56702/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message