mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Albert Strasheim <alb...@mesosphere.com>
Subject Re: Review Request 56052: Added the 'Secret' protobuf message.
Date Tue, 14 Feb 2017 22:49:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56052/#review165587
-----------------------------------------------------------




include/mesos/mesos.proto (line 1994)
<https://reviews.apache.org/r/56052/#comment237449>

    I believe pretty strongly that this should be bytes. Discussed with Greg.
    
    If I put bytes into a secret, I want to get bytes out.
    
    If my secret has a bunch of null bytes in the middle of it, it might not be suitable for
passing to the task as an env var, and I should use a file instead.
    
    I shouldn't have to change my app or write a script to transform secrets values.


- Albert Strasheim


On Feb. 9, 2017, 6:33 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56052/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 6:33 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Kapil Arya, Jan Schlicht, and Vinod Kone.
> 
> 
> Bugs: MESOS-6996
>     https://issues.apache.org/jira/browse/MESOS-6996
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new `Secret` protobuf message which
> is designed to serve as a generic mechanism for passing
> priviledged information within Mesos.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 34a288b6f5c2fca090a7aa7a61798e3255d6663a 
>   include/mesos/v1/mesos.proto 6638111d10f4a36cdf91dfce1019871e9839c306 
> 
> Diff: https://reviews.apache.org/r/56052/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message